chore: use sponge download api instead of hardcoded urls #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Aug 12, 2022
derklaro
added a commit
that referenced
this pull request
Aug 19, 2022
### Motivation Sponge provides a downloads api which allows to query the latest version of a sponge artifact. This is much nicer and removes the need to manually ensure that the download url of the sponge versions are always up-to-date. ### Modification Remove hardcoded sponge download urls from versions.json and replaced them with an install step which fetches the latest version from the sponge downloads api. ### Result Easy ensure that the downloaded version is always the latest one instead of relying on manual updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sponge provides a downloads api which allows to query the latest version of a sponge artifact. This is much nicer and removes the need to manually ensure that the download url of the sponge versions are always up-to-date.
Modification
Remove hardcoded sponge download urls from versions.json and replaced them with an install step which fetches the latest version from the sponge downloads api.
Result
Easy ensure that the downloaded version is always the latest one instead of relying on manual updates.