Xcode 12.0 GM build settings #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dnkoutso
approved these changes
Oct 8, 2020
amorde
force-pushed
the
segiddins/xcode-12-beta-1-build-settings
branch
from
a5094ec
to
9250fcc
Compare
segiddins
commented
Oct 8, 2020
| @@ -381,6 +380,7 @@ module Constants | |||
| 'CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF' => 'YES', | |||
| 'CLANG_WARN_OBJC_LITERAL_CONVERSION' => 'YES', | |||
| 'CLANG_WARN_OBJC_ROOT_CLASS' => 'YES_ERROR', | |||
| 'CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER' => 'YES', | |||
There was a problem hiding this comment.
I think this might require an update in cocoapods to turn it off?
There was a problem hiding this comment.
Should already be done in CocoaPods/CocoaPods#9905
There was a problem hiding this comment.
Yup already done in CocoaPods/CocoaPods#9905
There was a problem hiding this comment.
sorry I hadn't refreshed before commenting :D
amorde
force-pushed
the
segiddins/xcode-12-beta-1-build-settings
branch
from
9250fcc
to
0e96cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will require code changes, but this shows the default build settings diff