Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for disabling dependency analysis in run phase #789

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Add option for disabling dependency analysis in run phase #789

merged 1 commit into from
Oct 9, 2020

Conversation

LemonSpike
Copy link
Contributor

closes #785

@LemonSpike LemonSpike changed the title Add support for dependency analysis in shell script run phase Add option for disabling dependency analysis in run phase Sep 29, 2020
dnkoutso
dnkoutso reviewed Sep 29, 2020
View reviewed changes
lib/xcodeproj/project/object/build_phase.rb Outdated
# PBXShellScriptBuildPhase as `Based on
# dependency analysis` (selected by default).
#

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit empty line

dnkoutso
dnkoutso reviewed Sep 29, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -7,6 +7,9 @@
* Add support of c++ files (`hpp` and `cpp`) in `PBXFileReference:set_last_known_file_type`.
[romanmikhailov](https:/romanmikhailov)
[#783](https:/CocoaPods/Xcodeproj/issues/783)
* Add support of dependency analysis option in `PBXShellScriptBuildPhase:always_out_of_date`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add one line here.

Also add two empty spaces at the end of this line for markdown formatting.

@dnkoutso
Copy link
Contributor

Need to run bundle exec rubocop -a to fix linter issues.

@dnkoutso
Copy link
Contributor

Can you also rebase/squash? I can do it this during merge too.

@LemonSpike
Copy link
Contributor Author

LemonSpike commented Sep 29, 2020 •
edited
Loading

Is there a getting started guide for contributing to this repo and installing the gems on Mac? I'm getting build errors with sudo gem install ffi -v '1.9.17' --source 'https://rubygems.org/', so not sure what ruby version to use to get bundle install working, or how to set up. Thanks

@LemonSpike LemonSpike force-pushed the dependency_analysis_build_phase branch from 127f1bf to a3c89b7 Compare October 1, 2020 18:46
@LemonSpike
Copy link
Contributor Author

LemonSpike commented Oct 1, 2020 •
edited
Loading

@dnkoutso Rebase/squash done alongside rubocop. 😀 Hope we can merge this now.

@amorde amorde merged commit 651af88 into CocoaPods:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

@amorde amorde amorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xcodeproj doesn't know about the following attributes {"alwaysOutOfDate"=>"1"}
3 participants
@LemonSpike @dnkoutso @amorde