Lesson 8: onSale

[martijnvegmond-cw]

It's not a real issue, more of a question actually.

On this lesson the onSale property is used combined with the computed property sale. But when you change the onSale value, the p tag stays on the page and shows empty space. Is there a specific reason for it to do use it this way?

The way I see it, you could also use the following;

<p v-if="onSale">
<p v-shown="onSale">

And remove the check from the computed property.

[FelixSchwarz]

If the <p> tag is only displayed if the variant is on sale the rest of the page content would change its position making it hard to select the other variant. In general it seems good UI practice to keep the layout (mostly) the same even when the data changes.

Btw just a nitpick: the attribute is v-show (extra "n").