Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Better support for exclude config setting #233

Merged
merged 3 commits into from
Apr 12, 2015
Merged

Conversation

dkarzon
Copy link
Contributor

@dkarzon dkarzon commented Apr 1, 2015

Allows the exclude config setting to be used as well as pretzel > exclude and adds support for folder excludes instead of only by full path.

@laedit
Copy link
Member

laedit commented Apr 2, 2015

Thanks for the PR!

Good point about the config setting, but instead of duplicating the setting I think we should only accept the same as Jekyll: exclude.
And please add or modify tests, we don't accept code that is not tested.

One more thing, is it possible that you update the include setting as well?

Thanks.

@dkarzon
Copy link
Contributor Author

dkarzon commented Apr 4, 2015

That sounds like a better option, I'll update and write some tests for the new structure and update the PR.

@dkarzon
Copy link
Contributor Author

dkarzon commented Apr 6, 2015

@laedit Fixed

@laedit
Copy link
Member

laedit commented Apr 7, 2015

Great!
Is it possible to include a folder like you made possible to exclude one?

@laedit
Copy link
Member

laedit commented Apr 12, 2015

Excellent, thanks!

laedit pushed a commit that referenced this pull request Apr 12, 2015
Better support for exclude config setting
@laedit laedit merged commit f62c862 into Code52:master Apr 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants