This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Added support for specifying frontmatter defaults in _config.yml #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionality is based on: https://jekyllrb.com/docs/configuration/#front-matter-defaults Issue: #305 Note: I removed adding a fixed date of '2012-01-01' to the dictionary if not specified in the _config.yml. It was never used.
|
|
||
| public IDefaultsConfiguration GetDefaults() | ||
| { | ||
| return new DefaultsConfiguration(_config); |
There was a problem hiding this comment.
Since it is used with the site configuration, is it really necessary to instantiate a new defaults each time?
|
Thanks a lot, you are awesome! 😃 |
|
|
||
| Assert.Equal("default-author", defaults["author"]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you add a test which check that values in page/post's front matter have priority against defaults?
Moved DefaultsConfiguration to its own file. Converted GetDefaults() method to a property. Fixes #305
|
Excellent, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality is based on:
https://jekyllrb.com/docs/configuration/#front-matter-defaults
Resolves #305
Note: I removed adding a fixed date of '2012-01-01' to the dictionary if
not specified in the _config.yml. It was never used.