Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bad looking 'diff' code blocks with 'markdown' #6152

Merged
merged 5 commits into from
May 13, 2023
Merged

Update bad looking 'diff' code blocks with 'markdown' #6152

merged 5 commits into from
May 13, 2023

Conversation

rramboer
Copy link
Contributor

Description of the changes

Resolves #6003. Changed the cog and repo lists syntax highlighting within Discord to markdown from diff.

image

Have the changes in this PR been tested?

Yes

@rramboer rramboer requested a review from Jackenmen as a code owner May 13, 2023 08:33
@github-actions github-actions bot added the Category: Cogs - Downloader This is related to the Downloader cog. label May 13, 2023
@Jackenmen Jackenmen added this to the 3.5.2 milestone May 13, 2023
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label May 13, 2023
@github-actions github-actions bot added the Category: Cogs - Trivia This is related to the Trivia cog. label May 13, 2023
@Jackenmen Jackenmen changed the title change lang to markdown Update bad lookingcode blocks with 'diff' lang to use 'markdown' May 13, 2023
@Jackenmen Jackenmen changed the title Update bad lookingcode blocks with 'diff' lang to use 'markdown' Update bad looking code blocks with 'diff' lang to use 'markdown' May 13, 2023
Jackenmen
Jackenmen approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Jackenmen Jackenmen merged commit 6cd7a38 into Cog-Creators:V3/develop May 13, 2023
@Jackenmen Jackenmen changed the title Update bad looking code blocks with 'diff' lang to use 'markdown' Update bad looking 'diff' code blocks with 'markdown' May 13, 2023
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label May 13, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels May 14, 2023
@Flame442 Flame442 mentioned this pull request Mar 6, 2024
Open
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
@rramboer @Jackenmen @Dav-Git
Update bad looking 'diff' code blocks with 'markdown' (Cog-Creators#6152
a0f46eb 
)

Co-authored-by: Jakub Kuczys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees
No one assigned
Labels
Category: Cogs - Downloader This is related to the Downloader cog. Category: Cogs - Trivia This is related to the Trivia cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.

Remove the colors in Installed Cogs list
2 participants
@rramboer @Jackenmen