cleanups

ColoredCow · Jul 22, 2024 · 660ddf9 · 660ddf9
1 parent 4510b83
commit 660ddf9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/Modules/Salary/Http/Controllers/SalaryController.php b/Modules/Salary/Http/Controllers/SalaryController.php
@@ -71,7 +71,7 @@ public function generateAppraisalLetter(Request $request, Employee $employee)
  $pdf = $salaryService->getIncrementLetterPdf($request->all());
 
  return $pdf->inline($employee->user->name . '_Increment Letter_' . Carbon::parse($request->commencementDate)->format('jS F Y') . '.pdf');
- } else if ($employee->payroll_type === 'contractor') {
+ } elseif ($employee->payroll_type === 'contractor') {
  $pdf = $salaryService->getContractorOnboardingLetterPdf($request->all());
 
  return $pdf->inline($employee->user->name . '_Onboarding Letter_' . Carbon::parse($request->commencementDate)->format('jS F Y') . '.pdf');

diff --git a/Modules/Salary/Services/SalaryCalculationService.php b/Modules/Salary/Services/SalaryCalculationService.php
@@ -218,6 +218,4 @@ public function getContractorOnboardingLetterPdf($data)
 
  return $pdf;
  }
-
-
 }
diff --git a/Modules/Salary/Services/SalaryService.php b/Modules/Salary/Services/SalaryService.php
@@ -143,7 +143,7 @@ public function storeOrUpdateContractorSalary($request, $employee)
  $pdf = $salaryService->getIncrementLetterPdf($appraisalData);
  Mail::to($data['employeeEmail'])->send(new SendContractorIncrementLetterMail($data, $pdf->inline($data['employeeName'] . '_Increment Letter_' . $formattedCommencementDate . '.pdf'), $formattedCommencementDate));
  }
- 
+
  EmployeeSalary::create([
  'employee_id' => $employee->id,
  'monthly_fee' => $request->contractorFee,