Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed automatic hourly synchronization of efforts on the Portal #3714

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

AnirudhAP2k
Copy link
Contributor

@AnirudhAP2k AnirudhAP2k commented Sep 25, 2024

Targets #3713

Description of the changes

  • Fixed the condition for the $syncParams and added array_key_exists to validate the index.
  • Added modal for backDate sync confirmation.

Checklist:

  • The PR title follows this syntax: <#IssueID> <PR Title>
  • I have linked the issue id in the PR description.
  • I have performed a self-review of my own code.
  • I have added comments on my code changes where required.

Copy link
Contributor

Coverage report for commit: 11d53af
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 82.1%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.7%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 15.4%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 2.96% | Methods: 5.35%
FilesLinesMethodsBranches
app/Casts
   Decrypted.php--100.00%
app/Console/Commands
   CheckCommand.php--100.00%
   FakeProdDataCommand.php2.00%11.11%100.00%
   Setup.php--100.00%
app/Console
   Kernel.php10.53%50.00%100.00%
app/Exceptions
   Handler.php--100.00%
app/Helpers
   ContentHelper.php--100.00%
   DateHelper.php--100.00%
   DecimalToWordsHelper.php--100.00%
   FileHelper.php--100.00%
app/Http/Controllers/Auth
   ForgotPasswordController.php--100.00%
   LoginController.php--100.00%
   RegisterController.php--100.00%
   ResetPasswordController.php--100.00%
app/Http/Controllers/CRM
   CRMController.php--100.00%
app/Http/Controllers
   ClientController.php--100.00%
   CommentController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php26.47%50.00%100.00%
   ProjectController.php--100.00%
   ProjectStageController.php--100.00%
   UserBookController.php--100.00%
   UserController.php--100.00%
app/Http/Controllers/Finance
   InvoiceController.php--100.00%
   PaymentController.php--100.00%
   ReportsController.php--100.00%
app/Http/Controllers/HR/Applications
   VolunteerApplicationController.php--100.00%
app/Http/Controllers/HR/Volunteers
   CampaignsController.php--100.00%
   ReportsController.php--100.00%
   VolunteerOpportunityController.php--100.00%
app/Http/Controllers/KnowledgeCafe
   KnowledgeCafeController.php--100.00%
   WeeklyDoseController.php--100.00%
app/Http/Controllers/KnowledgeCafe/Library
   BookCategoryController.php--100.00%
   BookCommentController.php--100.00%
   BookController.php--100.00%
app/Http/Controllers/Settings
   BankDetailController.php--100.00%
   ConfigurationController.php--100.00%
   HRController.php--100.00%
   NDAAgreementController.php--100.00%
   PermissionController.php--100.00%
   SettingController.php--100.00%
app/Http
   Kernel.php100.00%100.00%100.00%
app/Http/Middleware
   EncryptCookies.php100.00%100.00%100.00%
   RedirectIfAuthenticated.php--100.00%
   TrimStrings.php100.00%100.00%100.00%
   TrustProxies.php100.00%100.00%100.00%
   VerifyCsrfToken.php100.00%100.00%100.00%
app/Http/Requests
   ClientRequest.php--100.00%
   ProjectRequest.php--100.00%
   ProjectStageRequest.php--100.00%
app/Http/Requests/Finance
   InvoiceRequest.php--100.00%
   PaymentRequest.php--100.00%
app/Http/Requests/KnowledgeCafe/Library
   BookCategoryRequest.php--100.00%
   BookRequest.php--100.00%
app/Http/Requests/KnowledgeCafe
   WeeklyDoseRequest.php--100.00%
app/Http/Requests/Setting
   SettingRequest.php--100.00%
   UpdateRolePermissionsRequest.php--100.00%
   UpdateUserRolesRequest.php--100.00%
app/Http/View/Composers
   CodeTrekApplicantsComposer.php100.00%100.00%100.00%
app/Imports
   ApplicationImport.php--100.00%
app/Listeners
   RemoveUserFromWebsite.php--100.00%
app/Mail
   DailyEffortSummary.php--100.00%
   ErrorReport.php--100.00%
   sendEmail.php--100.00%
app/Models
   BankDetails.php100.00%100.00%100.00%
   Category.php--100.00%
   Client.php--100.00%
   ClientCrmDetails.php--100.00%
   Comment.php--100.00%
   Country.php100.00%100.00%100.00%
   Project.php--100.00%
   ProjectStage.php--100.00%
   ProjectStageBilling.php--100.00%
   Resource.php--100.00%
   Setting.php--100.00%
   SkillSet.php100.00%100.00%100.00%
   Tag.php--100.00%
app/Models/Finance
   Invoice.php--100.00%
   Payment.php--100.00%
app/Models/Finance/PaymentModes
   Cash.php--100.00%
   Cheque.php--100.00%
   WireTransfer.php--100.00%
app/Models/KnowledgeCafe/Library
   Book.php13.79%13.64%100.00%
   BookAMonth.php--100.00%
   BookCategory.php--100.00%
app/Models/KnowledgeCafe
   WeeklyDose.php100.00%100.00%100.00%
app/Notifications
   ReviewNDA.php--100.00%
app/Observers
   UserObserver.php100.00%100.00%100.00%
app/Policies
   ClientPolicy.php--100.00%
   ProjectPolicy.php--100.00%
   SettingPolicy.php--100.00%
   UserPolicy.php--100.00%
app/Policies/Finance
   InvoicePolicy.php--100.00%
   ReportPolicy.php--100.00%
app/Policies/Infrastructure
   BillingsPolicy.php--100.00%
app/Policies/KnowledgeCafe/Library
   BookCategoryPolicy.php--100.00%
   BookPolicy.php--100.00%
app/Policies/KnowledgeCafe
   WeeklyDosePolicy.php--100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   ApplicantsComposerServiceProvider.php100.00%100.00%100.00%
   AuthServiceProvider.php100.00%100.00%100.00%
   BroadcastServiceProvider.php--100.00%
   DatabaseServiceProvider.php100.00%100.00%100.00%
   EventServiceProvider.php100.00%100.00%100.00%
   RouteServiceProvider.php100.00%100.00%100.00%
app/Rules
   TeamMemberDesignationRule.php--100.00%
   TeamMemberRule.php--100.00%
app/Services
   BookServices.php--100.00%
   CRMServices.php--100.00%
   CalendarEventService.php--100.00%
   EmployeeService.php--100.00%
   GSuiteUserService.php--100.00%
   SettingService.php--100.00%
   WebsiteUserService.php--100.00%
app/Traits
   Encryptable.php--100.00%
   Filters.php--100.00%
   HasTags.php--100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link

cypress bot commented Sep 25, 2024

Employee portal    Run #8813

Run Properties:  status check passed Passed #8813  •  git commit 27b14519fe ℹ️: Merge 11d53af6662a086b6ea6985bd117ee6d66f0d881 into 175da151f71fe951bafde2cc987c...
Project Employee portal
Branch Review refs/pull/3714/merge
Run status status check passed Passed #8813
Run duration 00m 28s
Commit git commit 27b14519fe ℹ️: Merge 11d53af6662a086b6ea6985bd117ee6d66f0d881 into 175da151f71fe951bafde2cc987c...
Committer Anirudh Panwar
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@AnirudhAP2k AnirudhAP2k changed the title Fixed effort sync during command execution + added backDate sync moda… Fixed effort sync during automatic hourly synchronization of efforts on the Portal Sep 25, 2024
@AnirudhAP2k AnirudhAP2k changed the title Fixed effort sync during automatic hourly synchronization of efforts on the Portal Fixed automatic hourly synchronization of efforts on the Portal Sep 25, 2024
@GauravGusain98 GauravGusain98 merged commit 32150f8 into master Sep 26, 2024
6 checks passed
@GauravGusain98 GauravGusain98 deleted the fix/effort-sync branch September 26, 2024 04:22
@GauravGusain98 GauravGusain98 mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants