feat: add validation function for other checks and use it for bas (fixes

 #393) (#405)

server/lib/validation/index.js

@@ -1,3 +1,4 @@
+const bas = require('./languages/bas');
 const en = require('./languages/en');
 const it = require('./languages/it');
 const ne = require('./languages/ne');
@@ -8,6 +9,7 @@ const ur = require('./languages/ur');
 const or = require('./languages/or');
 
 const VALIDATORS = {
+ bas,
  en,
  it,
  kab,
@@ -72,6 +74,8 @@ function validateSentence(validator, sentence) {
  validationResult.error = 'Contains multiple sentences';
  } else if (!validateWithoutEnglishCharacters(validator, sentence)) {
  validationResult.error = 'Contains English characters';
+ } else if (!validateOthers(validator, sentence)) {
+ validationResult.error = 'Other issues';
  }
 
  return validationResult;
@@ -131,6 +135,15 @@ function validateWithoutEnglishCharacters(validator, sentence) {
  return result;
 }
 
+function validateOthers(validator, sentence) {
+ const result =
+ typeof validator.filterOthers !== 'function'
+ ? true
+ : validator.filterOthers(sentence);
+
+ return result;
+}
+
 function getValidatorFor(language) {
  return VALIDATORS[language] || DEFAULT_VALIDATOR;
 }

server/lib/validation/languages/bas.js

@@ -0,0 +1,10 @@
+module.exports = {
+ filterOthers,
+};
+
+function filterOthers(sentence) {
+ return !sentence.endsWith(' .') &&
+ !sentence.endsWith('!.') &&
+ !sentence.endsWith(';') &&
+ !sentence.endsWith(',');
+}

server/tests/lib/validation/index.test.js

@@ -77,3 +77,20 @@ test('validates invalid sentences - english chars', validate, 'ru', {
  sentence: 'This too',
  error: 'Contains English characters',
 }]);
+
+test('validates invalid sentences - other rules', validate, 'bas', {
+ unreviewed: ['This is valid', 'This is wrong .', 'This as well!.', 'No;', 'Definitely not,'],
+ validated: ['This too'],
+}, [{
+ sentence: 'This is wrong .',
+ error: 'Other issues',
+}, {
+ sentence: 'This as well!.',
+ error: 'Other issues',
+}, {
+ sentence: 'No;',
+ error: 'Other issues',
+}, {
+ sentence: 'Definitely not,',
+ error: 'Other issues',
+}]);