Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Commit

Permalink
fix: better naming of language add button
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelKohler committed Mar 7, 2021
1 parent 9ee94a2 commit aa50e64
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion web/css/root.css
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ select {
}

main {
padding: 1rem 2rem;
max-width: 85vw;
margin: 0 auto;
}
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/add-language-section.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function AddLanguage({ allLanguages, onAdd, languages, pendingLan
labelText="Add a language you want to contribute to"
onChange={onLanguageSelect} />
<button disabled={pendingLanguages || !language}
onClick={onLanguageAdd} className="add-language">Add</button>
onClick={onLanguageAdd} className="add-language">Add Language</button>
</section>
);
}
2 changes: 1 addition & 1 deletion web/src/components/add-language-section.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const allLanguages = [{
test('should render submit button', () => {
render(<AddLanguageSection allLanguages={allLanguages}/>);
expect(screen.getByRole('button')).toBeTruthy();
expect(screen.getByText('Add')).toBeTruthy();
expect(screen.getByText('Add Language')).toBeTruthy();
});

test('should disable button on pending languages', () => {
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/header.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function Header() {
{/*
<section id="external-links">
<a target="_blank" rel="noopener noreferrer" href="https://discourse.mozilla.org/tags/c/voice/sentence-collection">Discourse</a>
<a target="_blank" rel="noopener noreferrer" href="https:/Common-Voice/sentence-collector/issues">Report Bugs (GitHub)</a>
<a target="_blank" rel="noopener noreferrer" href="https:/Common-Voice/sentence-collector/issues">Report Bugs</a>
<a target="_blank" rel="noopener noreferrer" href="https://discourse.mozilla.org/t/sentence-collector-copyright-issues/52767">Report copyright issues</a>
<a target="_blank" rel="noopener noreferrer" href="https://commonvoice.mozilla.org/privacy">Privacy</a>
<a target="_blank" rel="noopener noreferrer" href="https://commonvoice.mozilla.org/terms">Terms</a>
Expand Down

0 comments on commit aa50e64

Please sign in to comment.