This repository has been archived by the owner on May 10, 2023. It is now read-only.
Disallow emojis for Thai sentences #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it helps you can run |
Thanks Michael. I should go back to my another machine that has npm environment. |
|
🎉 This PR is included in version 2.3.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since mid-April 2021, Mozilla Thailand Community started to add more sentences via the Sentence Collector web interface (I believe this is a preparation towards their localization event on 25 April).
One of the thing few of the members do is exporting their own Twitter archive and add them to Sentence Collector.
@wannaphong has noticed that some of the sentences have emojis. So we need to reject or remove these emojis.