Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to ObservableValidator #3764

Merged

Conversation

Sergio0694
Copy link
Member

Fixes #3763

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • Incorrect loading of display names for validated properties
  • Repeated error messages after validation

What is the new behavior?

Fixed the errors above.

Opening as a draft to have the CI run, but I'm still investigating the second issue from the list above.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bugbash 🏗️ .NET Components which are .NET based (non UWP specific) mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package labels Feb 18, 2021
@Sergio0694 Sergio0694 added this to the 7.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi February 18, 2021 16:56
@ghost ghost requested review from Kyaa-dost and Rosuavio February 18, 2021 16:56
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior in progress 🚧 labels Feb 18, 2021
@Sergio0694 Sergio0694 marked this pull request as ready for review February 19, 2021 17:18
@Sergio0694
Copy link
Member Author

Marked as ready to review following the conversation in #3763 🙂

@Sergio0694 Sergio0694 force-pushed the bugfix/observablevalidator-errors branch from 750d570 to c7f262c Compare February 19, 2021 20:35
@michael-hawker
Copy link
Member

@RosarioPulella want to take a quick look at this one too?

@ghost
Copy link

ghost commented Feb 22, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Feb 22, 2021
@ghost ghost merged commit efaaf1b into CommunityToolkit:master Feb 22, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ in progress 🚧 mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package .NET Components which are .NET based (non UWP specific) next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new MVVM-Toolkit got some new bugs with the latest updated.
3 participants