-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should dataInput
of ClusterTree
be named "taxa"?
#1123
Comments
dataInput
of ClusterTree
be named "taxa"?dataInput
of ClusterTree
be named **"taxa"**?
dataInput
of ClusterTree
be named **"taxa"**?dataInput
of ClusterTree
be named __"taxa"__?
dataInput
of ClusterTree
be named __"taxa"__?dataInput
of ClusterTree
be named "taxa"?
@MordorianGuy you are right that It can be achieved by adding an extra Input and deprecating the old one, or creating a new type of input that is known by more than one name ( |
Thank you for your answer! Yes, you are right: the backward compatibility is hard. I have thought more about something like regex switches between versions applying to parsed XML based on the version attribute of the beast tag. If we definitely know what we changed between specific versions, we may apply these changes consequently to adjust an old XML to new standards. At least if we talk about simple renaming. |
beast2/src/beast/base/evolution/tree/ClusterTree.java
Line 68 in 67dd40a
The "taxa" xml-input name confounds my user's eye since it takes
Alignment
objects. Should it be renamed to "data" or "alignment"?P.S. One more point. By default, the BEAUti assigns the first partition as the input. It is not apparent and not expected behaviour. Maybe the unfiltered alignment would be better?
The text was updated successfully, but these errors were encountered: