restaking: Restaking oracle #334
Conversation
| let token_decimals = ctx.accounts.token_mint.decimals; | ||
|
|
||
| let amount_in_sol_decimals = (amount * | ||
| 10u64.pow(SOL_DECIMALS as u32)) / | ||
| 10u64.pow(token_decimals as u32); | ||
|
|
||
| let final_amount_in_sol = ((token_price.price * | ||
| (amount_in_sol_decimals as i64)) / | ||
| sol_price.price) as u64; |
There was a problem hiding this comment.
You can subtract rather than dividing. More importantly, I’m not
happy with the i64 and u64 conversions. Those need to be checked
rather than as. We have overflow checks for other operations but
as just interprets the bits.
| let token_decimals = ctx.accounts.token_mint.decimals; | |
| let amount_in_sol_decimals = (amount * | |
| 10u64.pow(SOL_DECIMALS as u32)) / | |
| 10u64.pow(token_decimals as u32); | |
| let final_amount_in_sol = ((token_price.price * | |
| (amount_in_sol_decimals as i64)) / | |
| sol_price.price) as u64; | |
| let decimals = SOL_DECIMALS - ctx.accounts.token_mint.decimals; | |
| let amount_in_sol_decimals = amount * 10u64.pow(decimals as u32); | |
| let amount_in_sol_decimals = | |
| i64::try_from(amount_in_sol_decimals).unwrap(); | |
| let final_amount_in_sol = token_price.price * | |
| amount_in_sol_decimals / | |
| sol_price.price; | |
| let final_amount_in_sol = | |
| u64::try_from(final_amount_in_sol).unwrap(); |
There was a problem hiding this comment.
the thing is that the token decimals can be more than solana decimals so i guess we could do smtg like this then
let decimals = (SOL_DECIMALS as i64) - (ctx.accounts.token_mint.decimals as i64);
let amount_in_sol_decimals = if decimals < 0 {
amount / 10u64.pow(abs(decimals))
} else {
amount * 10u64.pow(decimals)
}
There was a problem hiding this comment.
That makes sense, though prefer i64::from(...) to ... as i64. I also wonder if we should be concerned with rounding? I guess in this instance truncating is the correct approach.
| .find(|&&token_mint| token_mint == ctx.accounts.token_mint.key()) | ||
| .enumerate() | ||
| .find_map(|(index, &token_mint)| { | ||
| if token_mint == ctx.accounts.token_mint.key() { | ||
| return Some(index); | ||
| } | ||
| None | ||
| }) |
There was a problem hiding this comment.
Sounds like you’re looking for position.
| let token_price_update = &ctx.accounts.token_price_update; | ||
| let sol_price_update = &ctx.accounts.sol_price_update; | ||
|
|
||
| let sol_price_feed_id = SOL_PRICE_FEED_ID.to_string(); |
There was a problem hiding this comment.
because the feed id from hex expects &string and if i convert it there then the compiler complains saying use of moved value.
There was a problem hiding this comment.
I think what you want is:
let token_feed_id = staking_params
.token_oracle_addresses
.get(token_index)
.as_deref()
.unwrap_or(SOL_PRICE_FEED_ID);There was a problem hiding this comment.
oh ya i think deref is what was needed.
| .get(token_index) | ||
| .unwrap_or(&sol_price_feed_id); | ||
|
|
||
| let final_amount_in_sol = if token_feed_id == &sol_price_feed_id { |
There was a problem hiding this comment.
oh yes sorry, my bad.
|
So what happens when the token price changes? Do we ever re-evaluate it? |
|
Well no. We store the calculated value during deposit and use the same value to unstake. The thing is the user will get the same number of tokens, the conversion is only for validator stake so i guess its prolly fine. |
|
I’m just wondering about a case if someone deposits 1 FOO at a moment when it’s worth 1000 SOL. So we’re going to record it as 1000 SOL. But say month later it drops to 1 FOO = 1 SOL, but we will still treat this as worth 1000 SOL when calculating total stake and quorum. |
|
We would just enable stables for now else it's gonna get a bit tricky to update price everytime. |
|
OK, that makes more sense. Though even then between 2021 and now price of SOL fluctuated from 10 USD to 250 USD. ;) |
|
ill keep this in draft since we wont be using it for v1. |
Adding support to get price feed from oracle so that we can support staking of assets other than SOL and LSTs. The method gets the token price from oracle and then is divided by sol price to get in terms of sol. If the price feed id doesnt exist for tokens, then the solana price feed id is used as default.