Merge pull request #12 from bbugh/polymorphic-associations

Fixes preload_scope when association is polymorphic
ConsultingMD · May 21, 2018 · bdf7fc6 · bdf7fc6
2 parents add2d25 + 71322c7
commit bdf7fc6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/graphql/preload/loader.rb b/lib/graphql/preload/loader.rb
@@ -39,7 +39,10 @@ def perform(records)
  end
 
  private def preload_scope
- scope if scope.try(:klass) == model.reflect_on_association(association).klass
+ return nil unless scope
+ reflection = model.reflect_on_association(association)
+ raise ArgumentError, 'Cannot specify preload_scope for polymorphic associations' if reflection.polymorphic?
+ scope if scope.try(:klass) == reflection.klass
  end
 
  private def validate_association