Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq retries jobs that ActiveJob was instructed to discard #609

Open
CristinaRO opened this issue Apr 24, 2020 · 0 comments
Open

Sidekiq retries jobs that ActiveJob was instructed to discard #609

CristinaRO opened this issue Apr 24, 2020 · 0 comments

Comments

@CristinaRO
Copy link
Contributor

What happens:

  • the bulk user import fails because an InvalidSalesforceID exception is raised;
  • the ensure block deletes the uploaded file from the bucket;
  • Sidekiq (not ActiveJob!) retries the failed job anyway, because Sidekiq doesn't respect or acknowledge the discard_on instruction; that's an ActiveJob thing, too lowly for Sidekiq to bother with;
  • the job fails because the file is not there;
  • a baffling error appears in Rollbar.

Possible fix: instruct Sidekiq to not retry at all, by configuring sidekiq_options, and rely on ActiveJob's approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant