I’ve removed the pipeline restrictions for feature tests as I do not …

…think such restrictions are necessary. We originally had this restriction because some of the feature tests were flakey but this is no longer the case.

When we merge a PR it will run all the tests anyway so there is no point having PRs that pass but then release that fail due to a missed change. This will make PRs a bit longer but that should be fine.

.github/workflows/deploy_to_aws.yml

@@ -33,8 +33,6 @@ jobs:
 
  run-feature-tests:
  uses: ./.github/workflows/feature_tests.yml
- with:
- run_all_feature_tests: true
 
  deploy-to-application:
  runs-on: ubuntu-latest

.github/workflows/feature_tests.yml

@@ -2,12 +2,6 @@ name: "Run application feature tests"
 
 on:
  workflow_call:
- inputs:
- run_all_feature_tests:
- description: 'A trigger to run all the feature tests instead of a subset'
- default: false
- required: false
- type: boolean
 
 jobs:
  feature-test:
@@ -49,10 +43,5 @@ jobs:
  - name: Seed DB with test data
  run: bin/rails db:static
 
- - name: Run feature tests
- run: bin/rails cucumber:pipeline
- if: ${{ !inputs.run_all_feature_tests }}
-
  - name: Run all feature tests
  run: bin/rails cucumber:ok
- if: ${{ inputs.run_all_feature_tests }}

.github/workflows/rubyonrails.yml

@@ -19,5 +19,3 @@ jobs:
 
  run-feature-tests:
  uses: ./.github/workflows/feature_tests.yml
- with:
- run_all_feature_tests: ${{ github.event.pull_request.base.ref == 'preview' || github.event.pull_request.base.ref == 'production' }}

README.md

@@ -191,8 +191,7 @@ To run a specific feature test, use:
 bundle exec cucumber feature/path/to/feature.feature
 ```
 
-For Pull Requests, a subset of the feature tests are run (ones that have the `@pipeline` tag).
-However, all feature tests are run as part of the release process.
+All the feature tests are run as part of the Pull Request and release process
 
 #### Accessibility testing
 We use [Axe Cucumber][] to run accessibility tests but these are not run as part of the CI.

config/cucumber.yml

@@ -4,10 +4,8 @@ rerun = rerun.strip.gsub /\s/, ' '
 rerun_opts = rerun.empty? ? "--format #{ENV['CUCUMBER_FORMAT'] || 'progress'} features" : "--format #{ENV['CUCUMBER_FORMAT'] || 'pretty'} #{rerun}"
 std_opts = "--format #{ENV['CUCUMBER_FORMAT'] || 'pretty'} --strict --tags 'not @wip and not @accessibility' --publish-quiet "
 accessibility_opts = "--format #{ENV['CUCUMBER_FORMAT'] || 'pretty'} --strict --tags '@accessibility' --publish-quiet "
-pipeline_opts = "--format progress --strict --tags '@pipeline' --publish-quiet"
 %>
 default: <%= std_opts %> features
 wip: --tags @wip:3 --wip features --publish-quiet
 rerun: <%= rerun_opts %> --format rerun --out rerun.txt --strict --tags 'not @wip'
 accessibility: <%= accessibility_opts %> features/accessibility
-pipeline: <%= pipeline_opts %> features