Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREVIEW - Release 4.5.5 #3365

Merged
merged 48 commits into from
Nov 1, 2022
Merged

PREVIEW - Release 4.5.5 #3365

merged 48 commits into from
Nov 1, 2022

Conversation

tim-s-ccs
Copy link
Collaborator

In this release:

The following environment variable needs to be created/updated:

Variable Value
/Environment/global/MANAGEMENT_REPORT_KEY facilities_management/data/exports/facilities-management-rm6232-report.zip

tim-s-ccs and others added 30 commits September 29, 2022 17:11
… creating the cookie when the website is reloaded
Bumps [typescript](https:/Microsoft/TypeScript) from 4.7.4 to 4.8.4.
- [Release notes](https:/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.7.4...v4.8.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/core](https:/babel/babel/tree/HEAD/packages/babel-core) from 7.19.1 to 7.19.3.
- [Release notes](https:/babel/babel/releases)
- [Changelog](https:/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https:/babel/babel/commits/v7.19.3/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https:/eslint/eslint) from 8.22.0 to 8.24.0.
- [Release notes](https:/eslint/eslint/releases)
- [Changelog](https:/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.22.0...v8.24.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sinatra](https:/sinatra/sinatra) from 2.2.2 to 3.0.2.
- [Release notes](https:/sinatra/sinatra/releases)
- [Changelog](https:/sinatra/sinatra/blob/master/CHANGELOG.md)
- [Commits](sinatra/sinatra@v2.2.2...v3.0.2)

---
updated-dependencies:
- dependency-name: sinatra
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/parser](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.33.1 to 5.38.1.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.38.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/preset-env](https:/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.19.1 to 7.19.3.
- [Release notes](https:/babel/babel/releases)
- [Changelog](https:/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https:/babel/babel/commits/v7.19.3/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [active_storage_validations](https:/igorkasyanchuk/active_storage_validations) from 0.9.8 to 1.0.0.
- [Release notes](https:/igorkasyanchuk/active_storage_validations/releases)
- [Changelog](https:/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md)
- [Commits](igorkasyanchuk/active_storage_validations@0.9.8...1.0.0)

---
updated-dependencies:
- dependency-name: active_storage_validations
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https:/eslint/eslint) from 8.24.0 to 8.25.0.
- [Release notes](https:/eslint/eslint/releases)
- [Changelog](https:/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.24.0...v8.25.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [selenium-webdriver](https:/SeleniumHQ/selenium) from 4.4.0 to 4.5.0.
- [Release notes](https:/SeleniumHQ/selenium/releases)
- [Changelog](https:/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](SeleniumHQ/selenium@selenium-4.4.0...selenium-4.5.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sidekiq](https:/mperham/sidekiq) from 6.5.3 to 6.5.7.
- [Release notes](https:/mperham/sidekiq/releases)
- [Changelog](https:/mperham/sidekiq/blob/main/Changes.md)
- [Commits](sidekiq/sidekiq@v6.5.3...v6.5.7)

---
updated-dependencies:
- dependency-name: sidekiq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [geocoder](https:/alexreisner/geocoder) from 1.8.0 to 1.8.1.
- [Release notes](https:/alexreisner/geocoder/releases)
- [Changelog](https:/alexreisner/geocoder/blob/master/CHANGELOG.md)
- [Commits](alexreisner/geocoder@v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: geocoder
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [axe-core-cucumber](https:/dequelabs/axe-core-gems) from 4.4.1 to 4.4.2.
- [Release notes](https:/dequelabs/axe-core-gems/releases)
- [Changelog](https:/dequelabs/axe-core-gems/blob/develop/CHANGELOG.md)
- [Commits](https:/dequelabs/axe-core-gems/commits)

---
updated-dependencies:
- dependency-name: axe-core-cucumber
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/eslint-plugin](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.33.1 to 5.39.0.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.39.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/preset-env](https:/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.19.3 to 7.19.4.
- [Release notes](https:/babel/babel/releases)
- [Changelog](https:/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https:/babel/babel/commits/v7.19.4/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/parser](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.38.1 to 5.39.0.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.39.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…need to regularly export the FM data and upload it to S3.

I have added a new SideKiq worker which can get the data export and do this upload. I’ve also added the sidekiq cron job which we can use to schedule the job every week.

I have also refactored the `ManagementReportCsvGenerator` in the new framework to use the `ProcurementCsvExport` like in the old framework. This way we can generate the report without needing to have a management report.
I have removed the existing scripts related to the build_test on AWS. I have also moved the unit-test and feature-test jobs into separate workflows so they can be reused in other workflows.

I have created the workflow which should (hopefully) then deploy the code to the correct environments, but this still needs to be tested and sorted.
Bumps [actions/checkout](https:/actions/checkout) from 2 to 3.
- [Release notes](https:/actions/checkout/releases)
- [Changelog](https:/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/parser](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.39.0 to 5.40.0.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.40.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ruby/setup-ruby](https:/ruby/setup-ruby) from 1.101.0 to 1.117.0.
- [Release notes](https:/ruby/setup-ruby/releases)
- [Commits](ruby/setup-ruby@v1.101.0...v1.117.0)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/eslint-plugin](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.39.0 to 5.40.0.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.40.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pg](https:/ged/ruby-pg) from 1.4.3 to 1.4.4.
- [Release notes](https:/ged/ruby-pg/releases)
- [Changelog](https:/ged/ruby-pg/blob/master/History.rdoc)
- [Commits](ged/ruby-pg@v1.4.3...v1.4.4)

---
updated-dependencies:
- dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [fog-aws](https:/fog/fog-aws) from 3.14.0 to 3.15.0.
- [Release notes](https:/fog/fog-aws/releases)
- [Changelog](https:/fog/fog-aws/blob/master/CHANGELOG.md)
- [Commits](fog/fog-aws@v3.14.0...v3.15.0)

---
updated-dependencies:
- dependency-name: fog-aws
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tim-s-ccs/aws-codepipeline-action](https:/tim-s-ccs/aws-codepipeline-action) from 0.1.2 to 0.1.3.
- [Release notes](https:/tim-s-ccs/aws-codepipeline-action/releases)
- [Commits](Crown-Commercial-Service/ccs-aws-codepipeline-action@v0.1.2...v0.1.3)

---
updated-dependencies:
- dependency-name: tim-s-ccs/aws-codepipeline-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [paambaati/codeclimate-action](https:/paambaati/codeclimate-action) from 3.0.0 to 3.1.0.
- [Release notes](https:/paambaati/codeclimate-action/releases)
- [Changelog](https:/paambaati/codeclimate-action/blob/master/CHANGELOG.md)
- [Commits](paambaati/codeclimate-action@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: paambaati/codeclimate-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ruby/setup-ruby](https:/ruby/setup-ruby) from 1.117.0 to 1.118.0.
- [Release notes](https:/ruby/setup-ruby/releases)
- [Commits](ruby/setup-ruby@v1.117.0...v1.118.0)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
dependabot bot and others added 18 commits October 25, 2022 15:11
Bumps [axe-core-capybara](https:/dequelabs/axe-core-gems) from 4.4.1 to 4.4.2.
- [Release notes](https:/dequelabs/axe-core-gems/releases)
- [Changelog](https:/dequelabs/axe-core-gems/blob/develop/CHANGELOG.md)
- [Commits](https:/dequelabs/axe-core-gems/commits)

---
updated-dependencies:
- dependency-name: axe-core-capybara
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [aasm](https:/aasm/aasm) from 5.3.0 to 5.4.0.
- [Release notes](https:/aasm/aasm/releases)
- [Changelog](https:/aasm/aasm/blob/master/CHANGELOG.md)
- [Commits](https:/aasm/aasm/commits)

---
updated-dependencies:
- dependency-name: aasm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rubocop-rails](https:/rubocop/rubocop-rails) from 2.15.2 to 2.16.1.
- [Release notes](https:/rubocop/rubocop-rails/releases)
- [Changelog](https:/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.15.2...v2.16.1)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [notifications-ruby-client](https:/alphagov/notifications-ruby-client) from 5.3.0 to 5.4.0.
- [Release notes](https:/alphagov/notifications-ruby-client/releases)
- [Changelog](https:/alphagov/notifications-ruby-client/blob/master/CHANGELOG.md)
- [Commits](alphagov/notifications-ruby-client@5.3.0...5.4.0)

---
updated-dependencies:
- dependency-name: notifications-ruby-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ecause the service was not set up properly, the actual response received from cognito was not accounted for and so one of the parameters needed to log in was lost.

In this commit I have applied a code change which will fix this issue.

In addition, I have bitten the bullet somewhat and created feature tests for logging in so that we have better coverage of this area of the application. I have also added accessibility tests too.
Bumps [nokogiri](https:/sparklemotion/nokogiri) from 1.13.8 to 1.13.9.
- [Release notes](https:/sparklemotion/nokogiri/releases)
- [Changelog](https:/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.8...v1.13.9)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/parser](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.40.0 to 5.40.1.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/core](https:/babel/babel/tree/HEAD/packages/babel-core) from 7.19.3 to 7.19.6.
- [Release notes](https:/babel/babel/releases)
- [Changelog](https:/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https:/babel/babel/commits/v7.19.6/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [activerecord-import](https:/zdennis/activerecord-import) from 1.4.0 to 1.4.1.
- [Release notes](https:/zdennis/activerecord-import/releases)
- [Changelog](https:/zdennis/activerecord-import/blob/master/CHANGELOG.md)
- [Commits](zdennis/activerecord-import@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: activerecord-import
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [active_storage_validations](https:/igorkasyanchuk/active_storage_validations) from 1.0.0 to 1.0.2.
- [Release notes](https:/igorkasyanchuk/active_storage_validations/releases)
- [Changelog](https:/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md)
- [Commits](igorkasyanchuk/active_storage_validations@1.0.0...1.0.2)

---
updated-dependencies:
- dependency-name: active_storage_validations
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [aws-sdk-cognitoidentityprovider](https:/aws/aws-sdk-ruby) from 1.70.0 to 1.71.0.
- [Release notes](https:/aws/aws-sdk-ruby/releases)
- [Changelog](https:/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-cognitoidentityprovider/CHANGELOG.md)
- [Commits](https:/aws/aws-sdk-ruby/commits)

---
updated-dependencies:
- dependency-name: aws-sdk-cognitoidentityprovider
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https:/eslint/eslint) from 8.25.0 to 8.26.0.
- [Release notes](https:/eslint/eslint/releases)
- [Changelog](https:/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.25.0...v8.26.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rubocop](https:/rubocop/rubocop) from 1.36.0 to 1.37.0.
- [Release notes](https:/rubocop/rubocop/releases)
- [Changelog](https:/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.36.0...v1.37.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/eslint-plugin](https:/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.40.0 to 5.40.1.
- [Release notes](https:/typescript-eslint/typescript-eslint/releases)
- [Changelog](https:/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https:/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rspec-rails](https:/rspec/rspec-rails) and [rails](https:/rails/rails). These dependencies needed to be updated together.

Updates `rspec-rails` from 5.1.2 to 6.0.1
- [Release notes](https:/rspec/rspec-rails/releases)
- [Changelog](https:/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](rspec/rspec-rails@v5.1.2...v6.0.1)

Updates `rails` from 6.0.6 to 6.1.7
- [Release notes](https:/rails/rails/releases)
- [Commits](rails/rails@v6.0.6...v6.1.7)

---
updated-dependencies:
- dependency-name: rspec-rails
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…is, I’ve had to make the following changes:

- Add migration for changes to the active storage and make changes for the blobs controller
- Update `errors.keys` to `errors.attribute_names`
- Update the `application.html.erb` view spec due to changes with rspec-rails
- Fix an issue with the scope test
- Fix an issue with uploading documents
- Fix an issue with errors in the spreadsheet import
@tim-s-ccs tim-s-ccs merged commit a79e441 into preview Nov 1, 2022
@tim-s-ccs tim-s-ccs deleted the release-4.5.5 branch November 3, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant