FMFR-1323-allow-update-of-the-account-status #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domducsutcliffe
changed the title
tim-s-ccs
requested changes
Jan 17, 2023
| @@ -40,9 +40,9 @@ | |||
| <dd class="govuk-summary-list__value"> | |||
| <%= govuk_tag_with_text(*enabled_disabled_status_tag(@user.account_status)) %> | |||
| </dd> | |||
| <% if can_edit_user? %> | |||
| <% if can_edit_user? && permitted_sections.include?(:account_status) %> | |||
There was a problem hiding this comment.
Why have you added this? Is there an admin user type who cannot edit the account status?
There was a problem hiding this comment.
true no good reason
tim-s-ccs
requested changes
Jan 17, 2023
| @@ -40,9 +40,9 @@ | |||
| <dd class="govuk-summary-list__value"> | |||
| <%= govuk_tag_with_text(*enabled_disabled_status_tag(@user.account_status)) %> | |||
| </dd> | |||
| <% if can_edit_user? %> | |||
| <% if can_edit_user%> | |||
There was a problem hiding this comment.
You've taken too much off
Suggested change
| <% if can_edit_user%> | |
| <% if can_edit_user? %> |
…nge account status page
domducsutcliffe
force-pushed
the
feature/FMFR-1323-allow-update-of-the-account-status
branch
from
5936c2a
to
2165154
Compare
tim-s-ccs
approved these changes
Jan 17, 2023
domducsutcliffe
deleted the
feature/FMFR-1323-allow-update-of-the-account-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://crowncommercialservice.atlassian.net/jira/software/c/projects/FMFR/boards/71?modal=detail&selectedIssue=FMFR-1323