Added a feature where the user table only renders when a string is present in the search box #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domducsutcliffe
force-pushed
the
FMFR-1338-enhancements-to-user-search-feature-user-admin-section
branch
from
eda4fde
to
188c61f
Compare
tim-s-ccs
requested changes
Jan 27, 2023
...etplace/manage_users/user_admin/validations/find_users_javascript_enabled_validation.feature
Show resolved
Hide resolved
features/step_definitions/crown_marketplace/manage_users_steps.rb
Outdated
Show resolved
Hide resolved
domducsutcliffe
force-pushed
the
FMFR-1338-enhancements-to-user-search-feature-user-admin-section
branch
from
e18097c
to
c1c2f68
Compare
…esent in the search box
domducsutcliffe
force-pushed
the
FMFR-1338-enhancements-to-user-search-feature-user-admin-section
branch
from
0bdc1f8
to
6226877
Compare
…ure test to be more precise by targeting the css in the rendered partial
|
Believe I've made all the needed changes @tim-s-ccs |
tim-s-ccs
approved these changes
Jan 30, 2023
domducsutcliffe
deleted the
FMFR-1338-enhancements-to-user-search-feature-user-admin-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://crowncommercialservice.atlassian.net/jira/software/c/projects/FMFR/boards/71?modal=detail&selectedIssue=FMFR-1338
I have included an additional line in the background of a feature test, to reflect the new behaviour.