Enable new cops and make automatic and manual corrections to satisfy the new cops #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-s-ccs
force-pushed
the
enable-new-rubocop-cops
branch
2 times, most recently
from
de5ca9c
to
d60506a
Compare
tim-s-ccs
force-pushed
the
enable-new-rubocop-cops
branch
from
d60506a
to
9db4d5a
Compare
tim-s-ccs
force-pushed
the
enable-new-rubocop-cops
branch
from
9db4d5a
to
57e9870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have enabled new rubocops as I see no reason why we shouldn't be using them.