FMFR-1357 - Add ability to close FM frameworks #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-s-ccs
force-pushed
the
feature/FMFR-1357-update-the-frameworks-model-to-match-legacy
branch
from
1dfc939
to
4834312
Compare
…, we need to add that ability to the code base. Fortunately, this is something that already exists in the Legacy code base so I was able to basically copy and use that. Instead of having a `FacilitiesManagement::Framework` model, we instead have the `Framework` model with the `facilities_management` scope. I’ve updated the references where this was previously used to reflect these changes. Finally, I’ve updated some of the authentication controllers so that they can all make use of the framework status and do the right actions if there is an issue with the frameworks.
tim-s-ccs
force-pushed
the
feature/FMFR-1357-update-the-frameworks-model-to-match-legacy
branch
from
4834312
to
30c84a8
Compare
Chee-Ng
approved these changes
Mar 2, 2023
tim-s-ccs
deleted the
feature/FMFR-1357-update-the-frameworks-model-to-match-legacy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: FMFR-1357
As the RM3830 Facilities Management framework needs to be closed soon, we need to add that ability to the code base. Fortunately, this is something that already exists in the Legacy code base so I was able to basically copy and use that.
Instead of having a
FacilitiesManagement::Frameworkmodel, we instead have theFrameworkmodel with thefacilities_managementscope. I’ve updated the references where this was previously used to reflect these changes.Finally, I’ve updated some of the authentication controllers so that they can all make use of the framework status and do the right actions if there is an issue with the frameworks.