Update how we compile our assets #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-s-ccs
force-pushed
the
update-how-we-manage-assets
branch
5 times, most recently
from
9344441
to
94a0a84
Compare
tim-s-ccs
force-pushed
the
update-how-we-manage-assets
branch
from
94a0a84
to
03837d9
Compare
For CSS I’ve made use of [CSS Bundling for Rails](https:/rails/cssbundling-rails) with Dart Sass to compile our css (this did not require much change). More importantly, I’ve migrated from Webpack and Shakapacker to use Rollup to compile our Javascript. Our JavaScript setup is not that complicated and configuring and updating webpacker has been a pain point. Rollup is more simple to configure, is faster and the only downside is that we no longer get automatic page reloads when we make changes. I’ve also reorganised the tests so that we lint before running all the major tests (which should speed up CI and reduce the cost).
tim-s-ccs
force-pushed
the
update-how-we-manage-assets
branch
from
03837d9
to
6ec06ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve updated how our assets work, both CSS and JavaScript.
For CSS I’ve made use of CSS Bundling for Rails with Dart Sass to compile our css (this did not require much change).
More importantly, I’ve migrated from Webpack and Shakapacker to use Rollup to compile our Javascript. Our JavaScript setup is not that complicated and configuring and updating webpacker has been a pain point. Rollup is more simple to configure, is faster and the only downside is that we no longer get automatic page reloads when we make changes.
I’ve also reorganised the tests so that we lint before running all the major tests (which should speed up CI and reduce the cost).