Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api discovery #3973

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Api discovery #3973

wants to merge 2 commits into from

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

dsessler7
dsessler7 commented Aug 20, 2024
View reviewed changes
internal/controller/runtime/api_discovery.go Outdated Show resolved Hide resolved
internal/controller/runtime/api_discovery.go
var haveG string = apiG.Name
haveWantedAPIs[API{Group: haveG}] = struct{}{}

for _, apiGV := range apiG.Versions {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to loop through the Versions if we don't have the Group in wantAPIs? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expensive part was calling Kubernetes to retrieve the groups and versions. IMV, there's little benefit to discarding that information here.

internal/controller/runtime/api_discovery.go Show resolved Hide resolved
@cbandy cbandy mentioned this pull request Sep 26, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy cbandy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsessler7 @cbandy