Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tried upgrading major packages and reduced warnings #669

Closed
wants to merge 3 commits into from

Conversation

parjanya-rajput
Copy link
Contributor

You might need to look in github checks it always fails to run pub get Idk exactly what's wrong..Thank you

@guyluz11
Copy link
Member

guyluz11 commented Oct 1, 2023

I have fixed it now, please pull dev branch to your branch

Copy link
Member

@guyluz11 guyluz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you removed some essential code, the ide probably shows it as an error because you didn't run the generate code scripts.

Please run

dart run build_runner watch --delete-conflicting-outputs --use-polling-watcher

as described in the Wiki page
https:/CyBear-Jinni/cbj_app/wiki/Instructions-for-developers-and-testing

# Liquid progress indicator for Flutter.
liquid_progress_indicator_v2: ^0.5.0
liquid_progress_indicator: ^0.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is unsupported and didn't got update in 2 years
image

Please keep v2 version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I see that you started working on this branch and forked master instead of dev.
Please fork dev so that you will not add unwanted code that has already been solved in the flutter upgrade process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will do the necessary changes immediately

@guyluz11
Copy link
Member

guyluz11 commented Oct 2, 2023

Closing the PR for the pull requests tab to stay organized.
Please re-open the pr after playing the needed changes that I have mentioned.

Also my bad, it seems that I have merged one of the main prs to master accidentally and didn't understand why it was missing in your code.
My bad

@guyluz11 guyluz11 closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants