Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the dependencies and versions #679

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

andoriyaprashant
Copy link
Contributor

Fixes #665

Description

I've noticed several available updates and proactively upgraded dependencies. During this process, I conducted thorough testing with the updated dependencies and encountered no errors, which is a marked improvement from previous instances where errors were prevalent. By aligning certain dependencies with their compatible versions, I successfully resolved the previously encountered errors.

Screenshots of the changes -

image

  • I upgrade dependencies with the help of "flutter pub upgrade --major -version" command

image

  • Build gradle

image
image
image

@andoriyaprashant
Copy link
Contributor Author

Hello @guyluz11 please review my pull request #679
Thank you

android/build.gradle Outdated Show resolved Hide resolved
@guyluz11 guyluz11 changed the base branch from master to dev October 10, 2023 21:46
@guyluz11
Copy link
Member

guyluz11 commented Oct 10, 2023

I understand from what you wrote "improvement from previous instances where errors were prevalent" that you got out of the main branch, please fork and pr to dev next time
As you can see his last build passed
image

Also it looks like it does not pass ci, so also needs to be checked

@andoriyaprashant
Copy link
Contributor Author

I understand from what you wrote "improvement from previous instances where errors were prevalent" that you got out of the main branch, please fork and pr to dev next time As you can see his last build passed image

Also it looks like it does not pass ci, so also needs to be checked

I'll work from the dev branch next time, my apologies

@guyluz11 guyluz11 merged commit 925085e into CyBear-Jinni:dev Oct 12, 2023
1 check passed
@andoriyaprashant
Copy link
Contributor Author

Sorry for bothering you @guyluz11 , but could you please add the 'hacktobefest-accepted' label to this pull request
My pull request won't be approved without it
Thank you

@guyluz11 guyluz11 added the hacktoberfest-accepted Accept for hacktoberfest label Oct 12, 2023
@guyluz11
Copy link
Member

My bad, forgot about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade all pacakges to last version
2 participants