Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use license evidence for detected licenses #40

Closed
nscuro opened this issue Jul 16, 2021 · 0 comments
Closed

Use license evidence for detected licenses #40

nscuro opened this issue Jul 16, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nscuro
Copy link
Member

nscuro commented Jul 16, 2021

Quoting the README:

There is currently no standard way for developers to declare their module's license.
Detecting licenses based on files in a repository is a non-trivial task, which is why cyclonedx-gomod
uses pkg.go.dev to resolve module licenses (please read their license disclaimer).

While pkg.go.dev's license matching may be accurate most of the time, BOMs should state facts.
This is why license resolution is an opt-in feature (using the -licenses flag).
If you are a vendor and legally required to provide 100% accurate BOMs, do not use this feature.

We need to include this disclaimer, because the components/licenses node we're currently using represents an assertion.

Since v1.3 of the spec, there's now support for license evidence. Given that we perform error-prone license detection (or leverage services that do it for us), we should put detection results into the component/evidence/licenses node instead.

@nscuro nscuro added the enhancement New feature or request label Jul 16, 2021
@nscuro nscuro added this to the v1.0.0 milestone Jul 31, 2021
@nscuro nscuro self-assigned this Aug 1, 2021
@nscuro nscuro added the pending-release Implementation done, waiting for release label Aug 20, 2021
@nscuro nscuro closed this as completed in edd71cb Sep 24, 2021
@nscuro nscuro removed the pending-release Implementation done, waiting for release label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant