Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve site generation #458

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,23 @@
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
<version>3.1.0</version>
<executions>
<execution>
<phase>pre-site</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<target>
<copy file="${project.basedir}/README.md" tofile="${project.build.directory}/generated-site/markdown/index.md" />
</target>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
<pluginManagement>
<plugins>
Expand Down Expand Up @@ -445,6 +462,10 @@
<artifactId>maven-plugin-report-plugin</artifactId>
<version>${plugin-tools.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</reporting>

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/cyclonedx/maven/ModelConverter.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
import org.cyclonedx.model.Metadata;

/**
* Model converter from Maven concepts (Artifact + MavenProject) to CycloneDX ones
* (resp. pURL and Component + Metadata).
* Model converter from Maven concepts (dependency Artifact + MavenProject) to CycloneDX ones
* (resp. Component with pURL + Metadata).
*/
public interface ModelConverter {
String generatePackageUrl(Artifact artifact);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
import java.util.Map;

/**
* Converts a Maven Project with its Maven dependencies resolution graph transformed into a SBOM dependencies list
* with their dependsOn.
* Converts a Maven Project with its Maven dependencies resolution graph into a SBOM dependencies list
* with their {@code dependsOn}.
*/
public interface ProjectDependenciesConverter {

Expand Down
1 change: 1 addition & 0 deletions src/site/site.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
</item>
<!-- item name="Usage" href="usage.html"/>
<item name="FAQ" href="faq.html"/ -->
<item name="Javadoc" href="apidocs/index.html"/>
</menu>
<menu ref="reports"/>
</body>
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/BomDependenciesTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/256
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/256">issue #256</a>.
*
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/272
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/272">issue #272</a>:
* dependency has a bundle packaging which causes Maven's ProjectBuildingException
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/CIFriendlyTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/263
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/263">issue #263</a>:
* when makeAggregateBom using CI-friendly versions, root component does not list modules as dependencies
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/Issue116Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/116
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/116">issue #116</a>:
* dependencies in BOM file are missing a reference
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/Issue117Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/117
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/117">issue #117</a>:
* issue with pom.xml UTF-8 encoding with Byte Order Mark
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/Issue284Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/284
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/284">issue #284</a>:
* Fix filtering of scopes
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/Issue289Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/289
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/289">issue #289</a>:
* NPE when handling relocations
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/Issue311Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/311
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/311">issue #311</a>.
*/
@RunWith(MavenJUnitTestRunner.class)
@MavenVersions({"3.6.3"})
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/Issue64Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/64
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/64">issue #64</a>:
* include test scoped dependencies
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/cyclonedx/maven/VerboseTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import io.takari.maven.testing.executor.junit.MavenJUnitTestRunner;

/**
* test for https:/CycloneDX/cyclonedx-maven-plugin/issues/280
* test for <a href="https:/CycloneDX/cyclonedx-maven-plugin/issues/280">issue #280</a>:
* how to switch verbosity off by default, but let the user activate with CLI parameter
*/
@RunWith(MavenJUnitTestRunner.class)
Expand Down