Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added polars to extension list #1188

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Oct 16, 2024

User reported an issue where using pandera with polars raised the error. As identified by the user, this is because polars wasn't added to the list of supported extension.

Actual error: No registered subclass of BaseDefaultValidator is available for arg: schema and type <class 'polars.dataframe.frame.DataFrame'>. This either means (a) this arg-type contribution isn't supported or (b) this has not been added yet (but should be). In the case of (b), we welcome contributions. Get started at github.com/dagworks-inc/hamilton.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to dd74085 in 6 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/data_quality/pandera_validators.py:9
  • Draft comment:
    Typo in comment: TDOO should be TODO. This typo is also present on line 92.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR correctly adds 'polars' to the list of supported extensions, which should resolve the reported issue. However, there are some minor issues in the code that need addressing.
2. hamilton/data_quality/pandera_validators.py:9
  • Draft comment:
    Consider adding documentation for the addition of polars to the pandera_supported_extensions in the sphinx documentation under docs/ to inform users about the new support.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The change in the PR is straightforward and does not introduce any issues. However, the change should be documented in the sphinx documentation for clarity.

Workflow ID: wflow_k2MG7oIjfvb479TP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zilto zilto merged commit 5042cfd into main Oct 16, 2024
24 checks passed
@zilto zilto deleted the fix/add-polars-to-pandera-plugins branch October 16, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants