Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #393

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Update README.md #393

merged 12 commits into from
Sep 28, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

Updates the README to show hamilton does/does not

Looking to submit a Hamilton Dataflow to the sf-hamilton-contrib module? If so go the the Preview tab and select the appropriate sub-template:

Else remove this block.


[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Updates the README to show hamilton does/does not
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these could be tighter. We could get some feedback on it.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
elijahbenizzy and others added 11 commits September 28, 2023 06:13
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
Co-authored-by: Stefan Krawczyk <[email protected]>
@elijahbenizzy elijahbenizzy merged commit 2bf0b4d into main Sep 28, 2023
15 of 21 checks passed
@elijahbenizzy elijahbenizzy deleted the readme-updates branch September 28, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants