Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger hub build conditionally #401

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Trigger hub build conditionally #401

merged 2 commits into from
Sep 29, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Sep 28, 2023

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz skrawcz force-pushed the trigger_hub_build_conditionally branch 2 times, most recently from 09c86cd to f943c8e Compare September 29, 2023 01:16
@skrawcz
Adds hello_world contribution
a6c702d 
To show a basic dataflow and have people pull it in and start with it.
@skrawcz skrawcz force-pushed the trigger_hub_build_conditionally branch from f943c8e to fd1034c Compare September 29, 2023 05:08
@skrawcz skrawcz temporarily deployed to github-pages September 29, 2023 05:09 — with GitHub Actions Inactive
@skrawcz
Fixes hub github actions to run on PRs
5329f67 
We want to build the site for any contrib changes. But we
only want to deploy once merged to main. This adds
that conditional logic.
@skrawcz skrawcz force-pushed the trigger_hub_build_conditionally branch from fd1034c to 5329f67 Compare September 29, 2023 05:13
@skrawcz skrawcz merged commit a7b49e8 into main Sep 29, 2023
14 of 21 checks passed
@skrawcz skrawcz deleted the trigger_hub_build_conditionally branch September 29, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skrawcz