Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebook): add Jupyter Notebook for Prefect example #419

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

flaviassantos
Copy link
Contributor

@flaviassantos flaviassantos commented Oct 2, 2023

This pull request aims to address the issue #247 of ensuring that all examples within the project have accompanying Jupyter notebooks alongside the existing "run.py" files. This addition of Jupyter notebook covers the "Prefect" example.

Changes

Added a new Jupyter notebook.

How I tested this

I ran all the cells in the notebook successfully.

Notes

The notebook only mirrors the run.py, I did not write code the tips section.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@flaviassantos flaviassantos marked this pull request as draft October 2, 2023 04:42
@flaviassantos flaviassantos marked this pull request as ready for review October 2, 2023 04:42
@skrawcz skrawcz self-requested a review October 2, 2023 04:54
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flaviassantos ! Looks good.

@skrawcz skrawcz merged commit eda6ab3 into DAGWorks-Inc:main Oct 2, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants