type annotations edited to fix linting issue #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ def __new__(cls, name, bases, clsdict): | |||
| clsobj.__annotations__ = {} | |||
| return clsobj | |||
|
|
|||
| def __getattr__(cls, item: str) -> "MaterializerFactory": | |||
There was a problem hiding this comment.
We need to move these classes around too -- I can do that if you're slammed
There was a problem hiding this comment.
Hmm I think we don't -- this is now delayed in evaluation. So long as this doesn't break/complain if you put from __future__ import annotations then it should be fine!
elijahbenizzy
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylance (VSCode linter) would underline the entirety of materializers.
Changes
Elijah found the bug and asked to edit the type annotations of two methods
How I tested this
tests/integrationsandtests/plugins) successfully and