Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: large update to the concepts/ section #702

Merged
merged 17 commits into from
Feb 18, 2024
Merged

Docs: large update to the concepts/ section #702

merged 17 commits into from
Feb 18, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Feb 16, 2024

Multiple pages were updated from the docs concepts/ section.

Changes

  • pages added
  • content from blogs, examples, API references was integrated into Concepts pages
  • lexicon renamed to glossary
  • fixed a few random files that had outdated / incorrect code examples

How I tested this

  • ran pre-commit hooks
  • built documentation locally

Notes

  • ❗ would be beneficial to sprinkle links to tryhamilton.dev where relevant
  • ❗ there are a few #TODO left in the body of the text
  • would need a second pair of eyes to review the docs from the browser

@zilto zilto requested a review from skrawcz February 16, 2024 22:04
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zilto had to rebase to resolve conflict -- otherwise looks good. Do a squash merge and add a nice commit message.

@zilto zilto merged commit e00f144 into main Feb 18, 2024
24 checks passed
@zilto zilto deleted the docs/refactor branch February 18, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants