Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/integrations Ibis #722

Merged
merged 9 commits into from
Mar 1, 2024
Merged

docs/integrations Ibis #722

merged 9 commits into from
Mar 1, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Feb 29, 2024

Added documentation for Hamilton + Ibis.

Changes

  • added Ibis integration pages + updated the associated index

How I tested this

  • successfully built docs locally

Notes

  • This will be followed up by a blog post
  • Another PR is handling the examples/ibis changes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

docs/integrations/ibis/index.md Show resolved Hide resolved
docs/integrations/ibis/index.md Outdated Show resolved Hide resolved
docs/integrations/ibis/index.md Outdated Show resolved Hide resolved
docs/integrations/ibis/index.md Outdated Show resolved Hide resolved
docs/integrations/ibis/index.md Outdated Show resolved Hide resolved
docs/integrations/ibis/index.md Outdated Show resolved Hide resolved
docs/integrations/ibis/index.md Show resolved Hide resolved
docs/integrations/ibis/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good -- added wording tweaks.

@zilto zilto mentioned this pull request Mar 1, 2024
7 tasks
@skrawcz
Copy link
Collaborator

skrawcz commented Mar 1, 2024

nice squash commit and we're good to go!

@zilto zilto merged commit d4b4c71 into main Mar 1, 2024
23 checks passed
@zilto zilto deleted the docs/integrations/ibis branch March 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants