Updates docstring of data adapters to be public facing #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now fully public-facing, we just had not updated the docstring to show it.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to cbdca27
- Looked at
39lines of code in2files - Took 37 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. hamilton/io/data_adapters.py:115:
- Assessed confidence :
0% - Comment:
The removal of the comments makes sense as the API is now public-facing. The changes are clear and do not introduce any issues. - Reasoning:
The changes in this PR are straightforward and involve only the removal of some comments and a version update. The removed comments were warnings about the API not being public-facing, which is no longer the case. The version update is standard for a new release. There are no logical, performance, or security issues introduced by these changes.
Workflow ID: wflow_WyKtc8Kzvo0oxhRg
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
skrawcz
approved these changes
Mar 8, 2024
| @@ -1 +1 @@ | |||
| VERSION = (1, 52, 0) | |||
| VERSION = (1, 53, 0, "rc0") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick docstring update
Changes
How I tested this
Notes
Checklist
Summary:
This PR updates the docstrings of
DataLoaderandDataSaverclasses inhamilton/io/data_adapters.pyto reflect their public-facing status and increments the Hamilton library version to 1.53.0rc0.Key points:
DataLoaderandDataSaverclasses inhamilton/io/data_adapters.py.hamilton/version.py.Generated with ❤️ by ellipsis.dev