Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dask-expr to test dependency #760

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Adds dask-expr to test dependency #760

merged 3 commits into from
Mar 12, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Mar 12, 2024

So that tests don't fail -- dask now needs it as
a dependency.

Also turning using dask-expr off for tests.

Changes

  • requirements-test.txt
  • requirements-docs.txt
  • h_dask integration test conftest.py

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

So that tests don't fail -- dask now needs it as
a dependency.
Dask now requires this dependency.
So that we don't deal with having to update code
to run on dask-expr until we need to.
@skrawcz skrawcz merged commit bf8c9f5 into main Mar 12, 2024
23 checks passed
@skrawcz skrawcz deleted the fix_test_dep branch March 12, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant