Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make visualization nodes filled by default #765

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Mar 18, 2024

Previously, certain nodes types didn't have a style="filled".

Setting the visualization background color to transparent with graphviz_kwargs=dict(graph_attr=dict(bgcolor="transparent")) would also make nodes transparent. It is very hard to fix by user in an ad hoc way because of graphviz's quirks.

before
image

after
image

Changes

  • change default attributes
  • update tests accordingly

How I tested this

  • successfully ran the test suite locally

Notes

  • I am making this change to help with the VSCode Hamilton extension.
  • edges can be set to white or black for visibility depending on the background

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@zilto zilto requested a review from skrawcz March 18, 2024 15:38
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will break anyone's stuff. So looks good.

@skrawcz skrawcz merged commit 46471a3 into main Mar 18, 2024
23 checks passed
@skrawcz skrawcz deleted the fix/viz-default-fill branch March 18, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants