Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polars spreadsheet IO along with example and test case #776

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

swapdewalkar
Copy link
Contributor

@swapdewalkar swapdewalkar commented Mar 22, 2024

PR address 450

Changes

Polars spreadsheet IO along with example and test case.

How I tested this

Unit test
materialize example
script

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@swapdewalkar swapdewalkar changed the title Change done for polars spreadsheet changes Polars spreadsheet IO along with example and test case Mar 22, 2024
@skrawcz
Copy link
Collaborator

skrawcz commented Mar 22, 2024

Thanks @swapdewalkar for the update. But you need to rebase this please :) we need the updates from your other branch on it :)

# Conflicts:
#	examples/polars/materialization/my_script.py
#	examples/polars/materialization/notebook.ipynb
#	hamilton/plugins/polars_extensions.py
#	tests/plugins/test_polars_extensions.py
@skrawcz skrawcz merged commit 31da460 into DAGWorks-Inc:main Mar 25, 2024
23 checks passed
@skrawcz
Copy link
Collaborator

skrawcz commented Mar 25, 2024

Thanks @swapdewalkar I'll release this soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants