Bibdk2021 1324 bookmark work part2 #879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaspraem
approved these changes
Aug 29, 2023
| display: block; | ||
| } | ||
|
|
||
| .active i svg path { |
There was a problem hiding this comment.
Nu har vi den opsætning vi nu engang har. Man kan undgå denne lidt grimme css selector hvis man opretter svg'en som et react component, og sætter stroke og path til "currentColor" - så kan farven styres af css "color".
Da vi ikke har gjort dette før, så lad det ligge.
Du kunne evt spare "i" selector ved at give Icon dit classname istedet for at styre det med en parent.
| stroke: var(--blue); | ||
| } | ||
|
|
||
| .dropdownitem:focus i svg { |
There was a problem hiding this comment.
Kunne spare nogle linjer ved at duplikere selectore. Fx
.dropdownitem:hover i svg, .dropdownitem:focus i svg { display: block; }
Så længe det er den samme styling der skal applies
| await setBookmark(item); | ||
| const onSelect = (material, workId) => { | ||
| const item = { | ||
| key: workId + material, |
There was a problem hiding this comment.
Skal key ikke også bruge material[0] ?
* bug fixes (#883) * bug fixes * headerrow * space * init * to page * working populate * bookmark layout * checkbox functionality * disable logic * polish of layout * cleanup * translations --------- Co-authored-by: Yousef <[email protected]>
…dk-next-frontend into feature-bookmark
* orderhistory data consent modal * mutate * clean up * fixed translate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.