Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CGAL 6.0 breaking change. #1745

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fixing CGAL 6.0 breaking change. #1745

merged 3 commits into from
Oct 2, 2024

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Oct 1, 2024 •
edited
Loading

PR Description

CGAL 6.0 has no CGAL_USE_FILE anymore.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Oct 1, 2024

@JacquesOlivierLachaud @kerautret, could you please test the build of this PR activating CGAL on your system ?

@kerautret
Copy link
Member

@JacquesOlivierLachaud @kerautret, could you please test the build of this PR activating CGAL on your system ?

Thanks I look it, updating CGal from brew in progress...

kerautret
kerautret approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks perfect on my Mac, and DGtalTools also checked with CGal based tools well complied.👏🏻

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Oct 2, 2024

ok thanks, merging

@dcoeurjo dcoeurjo merged commit 90153d1 into master Oct 2, 2024
10 checks passed
@dcoeurjo dcoeurjo deleted the cgal6.0 branch October 2, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

@JacquesOlivierLachaud JacquesOlivierLachaud Awaiting requested review from JacquesOlivierLachaud

Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret