Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dec factory #1008

Merged
merged 48 commits into from
May 27, 2015
Merged

Dec factory #1008

merged 48 commits into from
May 27, 2015

Conversation

elcerdo
Copy link
Contributor

@elcerdo elcerdo commented May 6, 2015

moved dec constructor to dec factor.
added dec factory from collection of signed n-cells (compatible with digitalsurface).

@elcerdo
Copy link
Contributor Author

elcerdo commented May 6, 2015

#1007 and #977 must be merged first.

@elcerdo elcerdo mentioned this pull request May 11, 2015
Merged
@elcerdo elcerdo mentioned this pull request May 12, 2015
Merged
dcoeurjo
dcoeurjo reviewed May 18, 2015
View reviewed changes
src/DGtal/dec/DiscreteExteriorCalculusFactory.h
/**
* Create DEC structure from digital set.
* DEC embedded and ambient dimensions are equal to digital set point dimension.
* Set points get attached to primal n-cell <-> dual 0-cell.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points of the set ?

@dcoeurjo dcoeurjo mentioned this pull request May 20, 2015
Closed
dcoeurjo
dcoeurjo reviewed May 21, 2015
View reviewed changes
src/DGtal/dec/DiscreteExteriorCalculusFactory.ih
accumulateAllLowerIncidentCells(calculus.myKSpace, cell_border, lower_accum);
}
}
//DGtal::trace.warning() << "add_border=" << add_border << std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup ?

dcoeurjo
dcoeurjo reviewed May 25, 2015
View reviewed changes
src/DGtal/dec/doc/moduleDECPoisson.dox
@@ -161,6 +163,35 @@ This time DiscreteExteriorCalculusSolver.isValid is true after computing problem
\snippet exampleDiscreteExteriorCalculusSolve.cpp solve_ldlt
\image html solve_laplace_simplicial_ldlt.png "Poisson problem solution computed with simplicial LDLT solver. Solver solution is valid."

\section sectDECPoissonAlcapone Embedded 2D Poisson problem

In this example, we create a embedded 2D structure from a DigitalSurface and we solve a dual Poisson equation with Neumann boundaries condition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an embedded

@dcoeurjo
Copy link
Member

When running the exampleDECsurface, I get the following assert:

New Block [alcapone]
New Block [digital surface]
domain=[HyperRectDomain] = [[PointVector] {0, 0, 0}]x[[PointVector] {99, 99, 99}]
[ERR] Assertion Error - assertion (space().isSpaceClosed() && "[UmbrellaComputer] It is necessary to work with a closed cellular space since umbrellas use separators and pivots, which must exist for arbitrary surfels. Please build a closed KhalimskySpaceND for instance if you wish to work with faces in digital surfaces.") failed in void DGtal::UmbrellaComputer<DGtal::LightImplicitDigitalSurface<DGtal::KhalimskySpaceND<3, int>, FalseOutsideDomain<DGtal::ImageContainerBySTLVector<DGtal::HyperRectDomain<DGtal::SpaceND<3, int> >, bool>, DGtal::HyperRectDomain<DGtal::SpaceND<3, int> > > >::Tracker>::init(const DigitalSurfaceTracker &, Dimension, bool, Dimension) [TDigitalSurfaceTracker = DGtal::LightImplicitDigitalSurface<DGtal::KhalimskySpaceND<3, int>, FalseOutsideDomain<DGtal::ImageContainerBySTLVector<DGtal::HyperRectDomain<DGtal::SpaceND<3, int> >, bool>, DGtal::HyperRectDomain<DGtal::SpaceND<3, int> > > >::Tracker]: /Users/davidcoeurjolly/Sources/DGtal/src/DGtal/topology/UmbrellaComputer.ih(101)
[1] 59292 abort exampleDECSurface

@dcoeurjo
Copy link
Member

Great PR, thanks @elcerdo
Merging.

dcoeurjo added a commit that referenced this pull request May 27, 2015
@dcoeurjo
Merge pull request #1008 from elcerdo/DECFactory
818a28c 
Dec factory
@dcoeurjo dcoeurjo merged commit 818a28c into DGtal-team:master May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elcerdo @dcoeurjo