* Lambda-MST 2D/3D tangent estimator #1021
Conversation
copyme
commented
Jun 24, 2015
copyme
commented
- Naive3DDSSComputer - DSS computer which uses only valid projections
- Another related changes
* Naive3DDSSComputer - DSS computer which uses only valid projections * Another related changes
* This was a test code. Moreover, it contained a bugs (fixed in different branch) in the extendForward(), extendBackward()
|
I think you've got compiling errors because of some C++11 features (like using cbegin and cend ). Perhaps you should use them only when the flag CPP11 is on. |
|
@JacquesOlivierLachaud Ok I've check logs and I fixed problems related to CPP11 and documentation. Right now, we have one error but not related to my code. Do you have any other comments to the code? |
|
You are not listening to Mohamed's talk ? ----- Mail original ----- De: "kacperp" [email protected] @JacquesOlivierLachaud Ok I've check logs and I fixed problems related to CPP11 and documentation. Right now, we have one error but not related to my code. Do you have any other comments to the code? — |
|
Is this PR still active ? |
|
@dcoeurjo Yes, is still active. |
| * Description of class 'Standard3DDSSComputer' <p> | ||
| * \brief Aim: | ||
| * Dynamic recognition of a 3d-digital straight segment (DSS) | ||
|
|
There was a problem hiding this comment.
Is Naive3DDSSComputer a model of some Computer concept ?
http://dgtal.org/doc/nightly/moduleGridCurveAnalysis.html
... for instance the CDynamicBidirectionalSegmentComputer
I would suggest to add this in the doc, as well as models of these concepts.
|
@dcoeurjo @JacquesOlivierLachaud At this point what is not done yet:
Note sure if I will be able to finish this before end of this week. |
|
|
The problem with one Travis test was fixed in #1045. |
| @@ -96,6 +96,10 @@ | |||
| - Main example files of geometry/curves are introduced in the list of examples | |||
| and briefly described. | |||
| (Tristan Roussillon, [#1026](https:/DGtal-team/DGtal/pull/1026)) | |||
| - Lambda maximal segment tangent direction estimator 2D/3D: LambdaMST2D, LambdaMST3D. | |||
| (Kacper Pluta, [#1021](https:/DGtal-team/DGtal/pull/1021)) | |||
| - Segmentation of 3D digital curves by valid 2D projections onto base planes: NaiveDSS3DComputer. | |||
There was a problem hiding this comment.
i'm not sure to understand this sentence. do you mean
Segmentation of a 3D curve into maximal 3D DSS (defined by at least two valid 2D isothetic projections)
?
|
Thanks a lot @copyme for all your edits. BTW: why didn't you use Fraction class for Quotient type ? |
|
@dcoeurjo OK ChangeLog updated. No for Quotient I just used std::pair and I return integer parameters of a segment. |
|
Ok thanks, merging |
* Lambda-MST 2D/3D tangent estimator
