Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add key Shift-L to save configuration file. #1024

Merged
merged 2 commits into from
Jul 17, 2015

Conversation

kerautret
Copy link
Member

Tiny PR just to add new key to save viewing setting, usefull to compare in live two different view without the need to close the view...

@dcoeurjo
Copy link
Member

is the binding 'shift-M' ? not working on my system... what should I see when I click ?
BTW, would it be possible to add an entry in the help ?

@dcoeurjo dcoeurjo added this to the 0.9 milestone Jul 17, 2015
@kerautret
Copy link
Member Author

Sorry it is Shift-M.it is my fault ;(
The key is added in the help.
To test: load something displayed in 3DViewer. change the view, press Shft-L (record the viewer setting), change the view settings, and press L; it should go again on saved configuration.

@dcoeurjo
Copy link
Member

Shift-L / L works. What does Shift-M do ?

@kerautret
Copy link
Member Author

ok, Nothing special I think. ;)

@dcoeurjo
Copy link
Member

so it is SHIFT-L, right ? (title of the PR and the 'Sorry... ' comment) ?

@kerautret kerautret changed the title add key Shift-M to save configuration file. add key Shift-L to save configuration file. Jul 17, 2015
@kerautret
Copy link
Member Author

yes Shift -L , sorry I change the title for history ,;)

@dcoeurjo
Copy link
Member

ok great. Could you please just add a changelog entry ? E.g.

  • Shift-L / L key binding added to save and restore camera settings

?

@kerautret
Copy link
Member Author

yes done ;)

@dcoeurjo
Copy link
Member

merging, thanks

dcoeurjo added a commit that referenced this pull request Jul 17, 2015
add key Shift-L to save configuration file.
@dcoeurjo dcoeurjo merged commit f97cd55 into DGtal-team:master Jul 17, 2015
@kerautret kerautret deleted the AddKeyViewer3D branch November 7, 2015 21:41
@dcoeurjo dcoeurjo modified the milestones: 0.9, 0.9.2 Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants