Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Viewer3D improvements #1066

Merged
merged 2 commits into from
Nov 3, 2015
Merged

Minor Viewer3D improvements #1066

merged 2 commits into from
Nov 3, 2015

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Nov 1, 2015

  • Default background is lighter
  • The light position has been changed so that it is not axis aligned anymore
  • default window size is 800x600

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Nov 1, 2015

BTW, I don't understand why viewer3D-5-custom points have black edges..

@dcoeurjo dcoeurjo added this to the 0.9.1 milestone Nov 1, 2015
@@ -820,7 +820,7 @@ DGtal::Viewer3D<Space, KSpace>::init()
myGLScaleFactorY=1.0;
myGLScaleFactorZ=1.0;
myGLLineMinWidth=1.5;

setBackgroundColor ( QColor ( 217, 228, 255 ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the color ok but the dark one is no more present.
We can perhaps put the new one by default (instead white) and let the dark one associated to Key_B ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white background is still needed for exports and snapshots.
The idea of this PR is to replace the dark background (which is not great when displaying isothetic quads with classical lightning) by a "lighter" one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I see and we could later add a third 'dark' mode if needed.

@kerautret
Copy link
Member

else looks fine thanks

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Nov 2, 2015

Does the resize to 800x600 works on your machine?

@kerautret
Copy link
Member

yes it works, not you ? (at least for the examples)

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Nov 3, 2015

not always working.. strange...
Ready to merge?

@jlevallois
Copy link
Member

It's ok for me

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Nov 3, 2015

ok merging. thx

dcoeurjo added a commit that referenced this pull request Nov 3, 2015
Minor Viewer3D improvements
@dcoeurjo dcoeurjo merged commit 849f258 into DGtal-team:master Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants