-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move light position #1070
Move light position #1070
Conversation
The light source direction is also displayed during the light source move. |
@@ -13,6 +13,11 @@ | |||
- Minor improvements of default settings in Viewer3D. (David | |||
Coeurjolly, [#1066](https:/DGtal-team/DGtal/pull/1066)) | |||
|
|||
- New possibility to move the light source according to the mouse move in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... source using the mouse (with SHIFT key modifier) in Viewer3D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better thanks ;)
Nice feature ;) i'll test it |
done ;) |
x-y seems to be ok but I don't understand the "z" |
the position z of the light should change when you move the mouse according an y move (upper or lower). |
euh.. I don"t get it.. Are x (resp. y) moves increasing the phi angle (resp. theta) in a Euler representation ? |
yes exactly |
I fix a pb of direction update from the draw(), now it should be finer. The light source direction is always defined in the main system coords, and don't move with the camera. I think that this choice is better to simplify the user interaction with the definition of move. |
perfect!! thanks a lot |
Would it be possible to add a line in the documentation ? |
it in the help function but you mean in the main section ok I add it |
I meant in the module documentation |
done |
great |
add a new possibility to move light source position (an x-axis (resp. y-axis) mouse move changes the azimuth (resp. inclination angle) of the light source).