Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move light position #1070

Merged
merged 10 commits into from
Nov 5, 2015
Merged

Move light position #1070

merged 10 commits into from
Nov 5, 2015

Conversation

kerautret
Copy link
Member

add a new possibility to move light source position (an x-axis (resp. y-axis) mouse move changes the azimuth (resp. inclination angle) of the light source).

@kerautret
Copy link
Member Author

The light source direction is also displayed during the light source move.

@@ -13,6 +13,11 @@
- Minor improvements of default settings in Viewer3D. (David
Coeurjolly, [#1066](https:/DGtal-team/DGtal/pull/1066))

- New possibility to move the light source according to the mouse move in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... source using the mouse (with SHIFT key modifier) in Viewer3D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better thanks ;)

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 4, 2015

Nice feature ;) i'll test it

@kerautret
Copy link
Member Author

done ;)

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 4, 2015

x-y seems to be ok but I don't understand the "z"
BTW add the key binding (shift+CMD on mac..) in the changelog
and add something to say that the light always looks at (0,0,0)

@kerautret
Copy link
Member Author

the position z of the light should change when you move the mouse according an y move (upper or lower).
ok for the key

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 4, 2015

euh.. I don"t get it.. Are x (resp. y) moves increasing the phi angle (resp. theta) in a Euler representation ?

@kerautret
Copy link
Member Author

yes exactly

@kerautret
Copy link
Member Author

I fix a pb of direction update from the draw(), now it should be finer. The light source direction is always defined in the main system coords, and don't move with the camera. I think that this choice is better to simplify the user interaction with the definition of move.
Hope that it is also fine for you?

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 5, 2015

perfect!! thanks a lot

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 5, 2015

Would it be possible to add a line in the documentation ?

@kerautret
Copy link
Member Author

it in the help function but you mean in the main section ok I add it

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 5, 2015

I meant in the module documentation

@kerautret
Copy link
Member Author

done

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 5, 2015

great
merging

dcoeurjo added a commit that referenced this pull request Nov 5, 2015
@dcoeurjo dcoeurjo merged commit 1f4ca8b into DGtal-team:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants