Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug show() is called at the end of prg #1138

Merged
merged 3 commits into from
Mar 7, 2016

Conversation

kerautret
Copy link
Member

PR Description

Fix a bug which appears with this case of use:

viewer << Z3i::Point(0,0,0);
viewer << MyViewer::updateDisplay;
viewer.show();
return application.exec();

instead :

viewer.show();
viewer << Z3i::Point(0,0,0);
viewer << MyViewer::updateDisplay;
return application.exec();

Checklist

  • [n.a. ] Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • [n.a. ] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

dcoeurjo commented Mar 3, 2016

just wondering: can't we force the show() (when doing updateDisplay for instance) so that the user won't have to call this function ?

@kerautret
Copy link
Member Author

calling show() in qt is more to display the window on screen perhaps strange if we hide it (cc @akrah ?).
We could add a flag to check it but however sometimes to do offline screenshot it should be not good.

@@ -18,6 +18,10 @@


- *IO Package*

- Viewer3D: Fix a problem when the show() method was called at the of the main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the END of the main ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thanks

@dcoeurjo
Copy link
Member

dcoeurjo commented Mar 7, 2016

thanks merging.

dcoeurjo added a commit that referenced this pull request Mar 7, 2016
fix bug show() is called at the end of prg
@dcoeurjo dcoeurjo merged commit efb9e60 into DGtal-team:master Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants