Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix light render when change scale #1217

Merged
merged 2 commits into from
Nov 27, 2016
Merged

fix light render when change scale #1217

merged 2 commits into from
Nov 27, 2016

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Nov 12, 2016 •
edited
Loading

PR Description

Small fix that appears when changing the scale of the viewer:
capture d ecran 2016-11-12 a 12 39 48

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

@kerautret can you please have a look to #1214 ?

@kerautret
Copy link
Member Author

yes sorry I miss the comment ;) I have pushed a try..

@kerautret
Copy link
Member Author

@dcoeurjo merging ?

@dcoeurjo
Copy link
Member

all good. thanks.

@dcoeurjo dcoeurjo merged commit e8b9cc8 into DGtal-team:master Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerautret @dcoeurjo