Avoid enforcing std=c++11 when not necessary. #1222
Conversation
For example when the default flag of the compiler is std=gnu++11,c++14, etc...
|
I've just found this in cmake: https://cmake.org/cmake/help/v3.0/module/CheckCXXCompilerFlag.html and: CXX_STANDARD (since cmake 3.1) https://cmake.org/cmake/help/v3.1/prop_tgt/CXX_STANDARD.html#prop_tgt:CXX_STANDARD |
|
Thanks @phcerdan for the PR. Your edits look fine but I also think that using |
|
It does seem that CheckCXXCompilerFlag, and CheckCXXSourceCompiles, are wraps around try_compile. Also there is a new CXX_STANDARD variable, but it does not get passed to the CheckCXX... . See cmake bug: https://gitlab.kitware.com/cmake/cmake/issues/16456 So I think the existing try_compile is not that bad until cmake API stabilizes. |
|
Ok thanks |
|
Could you please add an entry to the change log ? |
|
Maybe we also should fix the DGtalConfig.cmake.in to re-discover cpp11 |
Add entry to ChangeLog.
phcerdan
force-pushed
the
avoid_add_c11_flag
branch
from
1efc073
to
2a00f00
Compare
|
DGtalConfig.cmake modified. |
So the std flag is not override by find_package(DGtal) This cover the case where: The user installed DGtal with flag std less than c++11, so DGtal added std=c++11. Then in an application linking to DGtal, the user decided to use a std flag greater than c++11. With old setup this was not possible, std flag gets override by find_package, even if the flag is more modern than c++11 as pointed in [DGtal-team#1219]. fix DGtal-team#1219
|
Excellent ! Thanks a lot. |
|
All good. merging. thanks again |
PR Description
Avoid enforcing flag
-std=c++11when not necessary.For example when the default flag of the compiler is
-std=gnu++11,c++14, etc... Or when the user explicitly set a std flag.
fix #1219
Checklist
Tested with gcc 6.2 that sets std=gnu++14 by default, and with gcc 5.4 that doesn't set any std flag.